kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,041 Commits 2 Branches 0 Tags
bbccb7667e1ff5cbcd7e8c5f1ad3ed438e5812d7
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Evangelos Ribeiro Tzaras bbccb7667e tests: util: Codestyle 2021-12-07 11:05:12 +01:00
Evangelos Ribeiro Tzaras 625b26be32 record-row: Codestyle 2021-12-07 11:05:12 +01:00
Evangelos Ribeiro Tzaras c37e9d8462 dbus: Add method to silence ringing 
Fixes #329
 2021-12-07 07:56:02 +00:00
Evangelos Ribeiro Tzaras 2d18667ee7 call-window: Use g_clear_handle_id instead of emulating it 2021-12-05 16:51:26 +01:00
Evangelos Ribeiro Tzaras 8f6ca20a2c call-window: Clear handle id when hiding call window 
This fixes GLib criticals like
GLib[464166]:CRITICAL: Source ID 17 was not found when attempting to remove it
 2021-12-05 16:50:19 +01:00
Evangelos Ribeiro Tzaras 85c23cfc3d test: ringer: Test quiet ringing 2021-12-05 10:04:05 +01:00
Evangelos Ribeiro Tzaras 0f72780814 ringer: Restart ringer if quiet parameter changed 
This makes sure the following sequence of events works:

- Call A incoming
- Rings loudly
- Call B incoming
- Still rings loudly
- Call A accepted
- Rings quietly
- Call A hung up
- Rings loudly again

Being able to restart the ringing is needed for this case because we cannot
retroactively change the feedback levels of a event that has already been
triggered.

Without this patch Calls would continue ringing for the scenario above even
after call A was accepted.
 2021-12-05 10:04:05 +01:00
Evangelos Ribeiro Tzaras b89f6a6f17 ringer: Add is-quiet property and getter 
This let's us query if the ringer is ringing quietly.
 2021-12-05 10:04:03 +01:00
Evangelos Ribeiro Tzaras 7dadb3c50f tests: Add ringer tests 
We mock libfeedback and CallsCall to test the ringer for the following
scenarios:
- Call state changes
- User requested silencing of ringer
- Multiple calls
 2021-12-05 09:50:25 +01:00
Evangelos Ribeiro Tzaras f86162da03 flatpak: Add cmocka dependency 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 9cdf46617f d/control: Add cmocka dependency 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 410cf8945a ringer: Check if incoming call is silenced 
Avoid ringing in this case.
 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 1587e4c78c call: Add API to silence ringing 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras f02d22150e ringer: Add debugging 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 9fff41fd53 ringer: Make sure to reset feedback profile if not set to "quiet" 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras e604779497 ringer: Don't warn if feedback triggering got cancelled 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 3e26294f3c ringer: Track ringer state 
This allows to cancel triggered feedbacks.
 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 1e5edea855 ringer: Disconnect signal handlers on dispose 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras fd7193a525 ringer: Refactor to keep track of ongoing calls 
This makes it easier to silence a call.
 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 17a2c94387 ringer: codestyle 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras f206b7d257 call: Rename property from "number" to "id" 
The term number is not necessarily accurate when dealing with f.e. SIP.
 2021-12-05 09:49:05 +01:00
Evangelos Ribeiro Tzaras 3e22ef8c74 record-store: Get rid of unused code 2021-12-02 05:52:44 +01:00
Evangelos Ribeiro Tzaras edfb4455f8 application: Chain up shutdown 2021-12-02 05:52:44 +01:00
Evangelos Ribeiro Tzaras 85689dbb45 history-box: Codestyle 2021-12-02 05:52:44 +01:00
Evangelos Ribeiro Tzaras aad6b85a2b application: Codestyle 2021-12-02 05:52:44 +01:00
Evangelos Ribeiro Tzaras 079fdcf441 d/changelog: Post-release version bump 
For the next releases we should update d/changelog sooner as this
ensures packages grabbed from CI will not be considered a downgrade
in Debian based distributions as can be seen below:

$ sudo dpkg -i gnome-calls_41.0+librem5ci338434.69db235c_arm64.deb
dpkg: warning: downgrading gnome-calls from 41.1-1pureos1 to 41.0+librem5ci338434.69db235c

Fixes #368
 2021-12-01 21:37:47 +01:00
Evangelos Ribeiro Tzaras fe7ebf51ce ci: Use PKG_ONLY variable to exclude flatpak job 
This makes sure we're not wasting computational resources when we only
want to build debian packages.
 2021-11-30 12:54:41 +01:00
Evangelos Ribeiro Tzaras 3b377edc81 ci: Drop debian bookworm packaging job 
It is very easy to either run locally with the run script or build
a package locally with `dpkg-buildpackage`.
 2021-11-30 12:54:41 +01:00
Evangelos Ribeiro Tzaras 89fd506f7d ci: Drop pedantic metainfo validation job 
And instead run them as a part of the regular tests.
 2021-11-30 12:05:27 +01:00
Evangelos Ribeiro Tzaras afe732d9bc flatpak: Poke hole to talk to feedbackd 
Without this ringtones and haptic feedback cannot work.

Fixes #363
 2021-11-26 08:42:36 +00:00
Evangelos Ribeiro Tzaras 529b35656b flatpak: Poke hole to talk to callaudiod 
Without this libcallaudio functionality (audio profile switching,
speakers and microphone muting cannot work.
 2021-11-26 08:42:36 +00:00
Evangelos Ribeiro Tzaras 04f43b2ce2 call-window: Delay closing window 
Fixes #301
 2021-11-25 19:14:42 +01:00
Evangelos Ribeiro Tzaras b083e588fa call-window: codestyle 2021-11-25 19:14:42 +01:00
Evangelos Ribeiro Tzaras 989a52fac5 record-row: Removed unused define 2021-11-25 19:14:42 +01:00
Evangelos Ribeiro Tzaras 56ec92d57f Update libcall-ui: Fix display showing number twice when not a contact 
This update also brings german translations.
 2021-11-25 19:14:42 +01:00
Evangelos Ribeiro Tzaras 5b6b7a7563 project: Post release version bump 
Fixes #364
 2021-11-25 18:35:15 +01:00
Evangelos Ribeiro Tzaras 7402cae903 ci: Fix regex for reporting code coverage 
We are now using gcovr instead of lcov after
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987818
has been closed.

The difference in output format tripped up reported code coverage in CI.
 2021-11-24 14:07:37 +01:00
Evangelos Ribeiro Tzaras a28d694623 dbus: Add API to send DTMF 
Addresses the calls side of #343
 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras 0761c4a53a dbus: Set can-dtmf property 
This lets consumers on DBus know if this call is capable of sending DTMF.
 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras 075dca5c35 tests: Add dtmf tone validity tests 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras afd1034dd1 util: Make dtmf tone checking function public 
Moves the function out of calls-call.c into util.c
 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras 4c2717c362 dummy: Add dummy send_dtmf_tone function 
This will allow DTMF to be tested UI wise when running the dummy plugin.
 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras acec33bb6c call: Get rid of unnecessary cast to int 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras a353a03d01 call: Get rid of tone_stop 
It wasn't used by any plugin backend and helps getting rid of a lot of code.
 2021-11-23 08:50:01 +00:00
Evangelos Ribeiro Tzaras 748f9c937c README: Add backend specific debugging information 2021-11-22 20:34:25 +00:00
Evangelos Ribeiro Tzaras 5a2727c0f4 README: Overhaul readme 2021-11-22 20:34:25 +00:00
Evangelos Ribeiro Tzaras d34a642f6e README: Mark oFono backend as not actively developed 
The ofono section was a bit too prominent in the README considering that it's
not actively developed.

The section was moved to its own file.
 2021-11-22 20:34:25 +00:00
Evangelos Ribeiro Tzaras cc7d83b26f README: Drop code coverage report 
This is now included as a badge in Gitlab.
 2021-11-22 20:34:25 +00:00
Evangelos Ribeiro Tzaras 2bbb923226 call-data: Notify on avatar changes 
Otherwise the call display will not update.
 2021-11-19 15:56:45 +01:00
Evangelos Ribeiro Tzaras 5919182c17 Update libcall-ui 
This has the display name property of CuiCall wired up to CuiDisplay
so that property changes are reflected in the UI.
 2021-11-19 15:56:45 +01:00
Evangelos Ribeiro Tzaras cfac02a00c call-data: Fix assertion in notify handlers 2021-11-19 15:56:45 +01:00
Evangelos Ribeiro Tzaras da648829b4 best-match: Rename best_match variable to matched_individual 
This makes it a bit clearer what the variable is used for.
 2021-11-19 15:56:45 +01:00
Evangelos Ribeiro Tzaras dc96d892f5 Remove encryption indicator 
Not used anymore since we switched to libcall-ui.
Should've been removed as a part of !425.
 2021-11-19 15:56:37 +01:00
Evangelos Ribeiro Tzaras 3aba0bf34d po: Remove call display files 
The call display was removed in !425 and this should've been part of edd85602.
 2021-11-19 15:56:37 +01:00
Evangelos Ribeiro Tzaras 76ec1e6941 record-row: Use avatars in history 
Fixes #147
 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras 4e9eedb5fa call-data: Implement avatar property 
Fixes #161
 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras c3dd169432 Update libcall-ui submodule 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras ff96d70ac7 meson: Don't build tests, examples or documentation for libcall-ui 
Not necessary when building Calls.
 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras 719f11f42b coverage: Exclude subprojects and generated dbus code 2021-11-18 12:15:25 +01:00
Evangelos Ribeiro Tzaras 4c44284bd1 ci: Use gcovr for coverage reports 2021-11-18 12:15:21 +01:00
Evangelos Ribeiro Tzaras edd8560291 Remove CallsCallDisplay 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras dc454837d6 Switch from CallsCallDisplay to CuiCallDisplay 
Closes #302
 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras 4321381f23 Introduce CallsUiCallData to feed CuiDisplay 
We need a proxy object because implementing the CuiCall interface in the
CallsCall base class has it's own set of problems (f.e. the "state" property
would have a type collision CallsCallState vs CuiCallState).
 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras c5636ab71c call: Add API to query whether this call can do DTMF 
This allows enable or disable UI elements.
 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras bf72169f68 application: Initialize libcall-ui 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras 8cb2c09f7b Add libcall-ui as submodule 
This is meant to ease sharing the call ui between calls and phosh.
 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras f44f643ae9 ci: Complain about untranslated ui files 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras daebcf543a po: Ignore subprojects 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras 2ce0c7775c ci: Grab submodules by setting GIT_SUBMODULE_STRATEGY 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras ac4150139d call-window: Remove unused CALLS_WAYLAND ifdef 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras f985332a37 Remove unused typedef 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras 620804ab01 main-window: Remove unused header 2021-11-16 09:39:34 +01:00
Evangelos Ribeiro Tzaras cb640321ca flatpak: Update manifest 2021-11-16 08:53:04 +01:00
Evangelos Ribeiro Tzaras 62208c5571 ci: Update from flatpak CI template 2021-11-16 08:53:04 +01:00
Evangelos Ribeiro Tzaras 2cf7c5e981 sip: origin: Make sure "@host" is in the dial string 
This helps avoid some typing work in the case of dialing telephone numbers.

Fixes #350
 2021-10-30 18:49:27 +02:00
Evangelos Ribeiro Tzaras 1b4e968e8e sip: origin: Bail when trying to dial empty string 2021-10-30 18:49:27 +02:00
Evangelos Ribeiro Tzaras 2fc5533e1a call-window: Improve readability of remove_call function 
The casual reader might be tricked into believing CallsCallSelectorItem would
leak here, which was not actually the case.
 2021-10-28 14:51:19 +00:00
Evangelos Ribeiro Tzaras d7d97e8f67 call-window: Remove unnecessary code 
As the "visible-child-name" from main_stack and header_bar_stack is already
bidirectionally bound.
 2021-10-28 15:56:14 +02:00
Evangelos Ribeiro Tzaras 6ca9076b4a po: Add missing files to POTFILES.in 
These files were adding translatable texts.
 2021-10-27 16:27:11 +02:00
Evangelos Ribeiro Tzaras 4593a82b21 number-query: Fall back to string comparison if parsing EPhoneNumber fails 
Fixes #345
 2021-10-27 11:07:54 +00:00
Evangelos Ribeiro Tzaras a1409089f0 screenshots: Remove shell chrome 
Fixes #347
 2021-10-27 10:08:34 +02:00
Evangelos Ribeiro Tzaras 94d730c3ed Let provider plugin decide whether to automatically hang up secondary calls 
Revert "manager: hang up secondary calls"

This reverts commit 94345e0916 and moves that
functionality to the ModemManager plugin.

Fixes #290
 2021-10-22 06:00:45 +02:00
Evangelos Ribeiro Tzaras 21eb12e9b1 dummy-call: Simplify change_state() 2021-10-22 04:58:01 +02:00
Evangelos Ribeiro Tzaras db2bb818b6 ci: Use appstreamcli instead of appstream-util 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras f828f24591 metainfo: Add URL tag for translations 
See
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-url
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras 41a4d64db5 metainfo: Add "translation" tag 
See
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-translation
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras a0208c7119 metainfo: Add "launchable" tag 
See
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras a723a66767 metainfo: Replace deprecated GPL license identifier 
It is deprecated according to https://spdx.org/licenses/GPL-3.0+.html
and GPL-3.0-or-later should be used instead.
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras dd22510516 metainfo: Update description 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras 44689ddf34 metainfo: Update summary 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras f42d060715 metainfo: Add "requires" tag in favour of custom tags 
As described in
https://blogs.gnome.org/tbernard/2021/09/07/ready-for-software-41/
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras e46af8fc53 metainfo: Simplify content rating 
To quote the spec:

In case the <content_rating/> tag is empty (no <content_attribute/> is present),
it is assumed that the component was checked for age ratings and no age
restrictions apply.

Source:
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-content_rating
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras aaaf32cf10 metainfo: Add notification "kudo" tag 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras f966046c9a metainfo: Remove "developer_name" tag 
`appstreamcli` complains about the tag being duplicated and we are not losing
anything since credit is given in all the license headers.
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras 7ca0bca62a metainfo: Add DBus service to "provides" tag 
See
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-provides
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras 7b904dc324 metainfo: "mimetypes" tag is deprecated 
See
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-mimetypes
 2021-10-21 09:54:12 +00:00
Evangelos Ribeiro Tzaras 43fb8504e8 ci: Run relaxed appstream validation during tests 
If appstream-util is installed the tests will run `appstream validate-relax` on
the metainfo file.
 2021-10-19 12:37:08 +02:00
Evangelos Ribeiro Tzaras 65f487f1e8 ci: Use strict metadata validation, but allow it to fail 
Validation will fail because the screenshots height is too large and not using a
16:9 aspect ratio:

• attribute-invalid     : <screenshot> height too large
  [https://gitlab.gnome.org/GNOME/calls/raw/master/data/screenshots/history.png]
  maximum is 900px

• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9
  [https://gitlab.gnome.org/GNOME/calls/raw/master/data/screenshots/calling.png]

The strict validation will nevertheless provide valuable information.
 2021-10-19 12:37:08 +02:00
Evangelos Ribeiro Tzaras eb0bf0abf4 ci: Upgrade certificates 
Fixes #346
 2021-10-19 12:37:05 +02:00
Evangelos Ribeiro Tzaras 1306628f8c metainfo: Add screenshots 
Fixes #341
 2021-10-19 08:40:57 +00:00