kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
670 Commits 2 Branches 0 Tags
588955b59e0799b4e3d0e2530a179b6f41abfec5
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Evangelos Ribeiro Tzaras 588955b59e display: codestyle 2021-06-03 19:46:45 +00:00
Evangelos Ribeiro Tzaras 8d937bedf6 Initial DBus API 2021-06-03 14:29:36 +00:00
Evangelos Ribeiro Tzaras 2ae79ea06f Update README: Explain how to start calls without installing 
Additionally get rid of the /usr/local/stow/calls-git prefix.
 2021-06-03 13:27:56 +02:00
Evangelos Ribeiro Tzaras 04b81dd664 Add run script to the build directory 
This allows starting calls by invoking something like _build/run.

Closes #292
 2021-06-03 13:13:33 +02:00
Evangelos Ribeiro Tzaras 3d51d627d3 meson: Compile schemas in build directory 
To make it easier to run from the build directory without having to install.
 2021-06-03 12:54:46 +02:00
Evangelos Ribeiro Tzaras 23944acc91 d/control: Add libxml2-utils 
We are requesting xml-stripblanks in gresources.xml and are missing
xmllint without this dependency.
 2021-06-03 12:43:01 +02:00
Evangelos Ribeiro Tzaras 538d98f21d ci: disable flatpak build 
Reenable the build after the build failures from #291 have been sorted out.
 2021-06-02 12:22:43 +02:00
Evangelos Ribeiro Tzaras cb533aabb7 manager: Update country code 
By connecting to the "notify::country-code" signal of our origins.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 7d3426598d application: settings: Add country code setting 
This helps to unbreak country code lookup (see 5fd39121).
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 4990529c6c tests: manager: Add multiple provider tests 
The test suite can be further expanded later. For now this suffices to
have some basic regression testing for multiple provider support in place.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras dde4bd8abf sip: provider: Don't warn when trying to add account multiple times 
A g_debug() will suffice which will let us get rid of g_test_expect_message() to
as we don't need to guard against the warning anymore.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 9c91a33604 test: manager: Use more appropriate g_assert_*() calls 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 44f2002f86 manager: Differentiate the NO_ORIGIN state 
This avoids confusion when only the SIP plugin is loaded, but no account
is being used.

For this we introduce two new functions in the abstract CallsProvider class:
`is_modem()` to indicate whether the the provider deals with PTSN telephony and
`is_operational()` which by default simply checks if there any avalaible origins
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 98d66743a1 application: Don't add a provider if one is already present 
If we initially invoked `gnome-calls -p sip` and later invoke
`gnome-calls sip:user@host` we don't expect to have the default MM provider
added.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 3f3b108cea new-call-box: Honour auto-use-default-origins setting 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras fef1531749 application: Add CallsSettings class 
This makes it easy to access application wide settings.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras 0b2f146053 manager: support multiple providers 
This includes the following changes:
- Introduce a `providers` hash table to keep track of multiple CallProvider's
  and remove the `provider` member
- Remove `calls_manager_get_provider()` and `calls_manager_set_provider()`
  in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()`
  and `calls_manager_has_provider()`
- Introduce a `origins` GListStore to keep track of available origins.
  `origins` is updated in `items_changed_cb()` when the origins of any
  CallsProvider are updated.
- Adapt to changes with respect to `calls_manager_get_origins()`.
- Introduce `origins_by_protocol` hash table to keep track of available origins
  per protocol.
- Adjust tests
- We temporarily break country code lookup which was handled previously
  with the "default-origin" mechanism. We will add it back to the CallsSettings
  class which will provide a better application-wide mechanism.
 2021-06-01 14:52:18 +02:00
Evangelos Ribeiro Tzaras 0c966fdf83 origin: Add API to query supported protocols 
This will allow selecting a suitable origin when placing outgoing calls.
 2021-05-28 17:02:02 +02:00
Evangelos Ribeiro Tzaras 7ad0f4cdd6 provider: Add API to query supported protocols 
These are the protocols that the provider plugin may support. The origins
must be queried independently whether or not they support any given protocol.

Example: A SIP origin/account may or may not support the "tel" protocol.
 2021-05-28 17:02:02 +02:00
Evangelos Ribeiro Tzaras 6d8c227b24 calls-record: Introduce the protocol property 
This is in preparation for supporting multiple providers (which are handling
different protocols/URI schemes).

This commit also changes the underlying database schema.
 2021-05-28 17:02:02 +02:00
Evangelos Ribeiro Tzaras 53f69b06dd call: Introduce protocol property 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 503e5c2154 test: Add util tests 
Unit test the `get_protocol_from_address()` function family.
 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 1e84812938 util: Add simple API to query protocol 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 1def4c3585 plugins: provider: Use CallsOrigin instead of derived types for GListStore 
Otherwise we run into trouble when using `g_list_store_find()`
 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 80ec7d8a35 account-provider: Add debugging in the public functions 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras a888ac54b1 mm: origin: Try using own number as the origin name 
This will make it easier to select an origin for outgoing calls. Without this
change the name might be "0" which is not very expressive.
 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras fecdc1fff8 cleanup: Fix calls_origin_get_name() related memory leaks 
Document calls_origin_get_name() correctly as transfer-full.
Additionaly fix related memory leaks.
 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 1543802c88 provider: whitespace and indentation 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras 2ac43f391a manager: Set peas search path only once 
There is no need to redo it for every added plugin.
 2021-05-20 02:52:11 +02:00
Evangelos Ribeiro Tzaras 3121963220 Document and release 0.3.3 2021-05-19 18:15:00 +02:00
Evangelos Ribeiro Tzaras 1db1ba6ca9 test: Add account tests 2021-05-04 06:48:36 +02:00
Evangelos Ribeiro Tzaras 95f16cb527 sip: provider: Implement CallsAccountProvider interface 2021-05-04 06:44:43 +02:00
Evangelos Ribeiro Tzaras 14ef4f6b17 Add CallsAccountProviderInterface 
This interface should by implemented by providers for which the user can add
or remove accounts.
 2021-05-04 06:41:43 +02:00
Evangelos Ribeiro Tzaras 36cd9bd122 sip: provider: return origin in calls_sip_provider_add_origin() 2021-05-04 05:58:41 +02:00
Evangelos Ribeiro Tzaras a6cb02a4c9 sip: provider: codestyle 2021-05-04 05:58:41 +02:00
Evangelos Ribeiro Tzaras 3edd6d002b sip: origin: Implement CallsAccountsInterface 2021-05-04 05:57:42 +02:00
Evangelos Ribeiro Tzaras 781adaddee sip: origin: Use CallsAccountState instead of SipAccountState 2021-05-04 05:57:42 +02:00
Evangelos Ribeiro Tzaras 0e5bd82568 Add CallsAccountInterface 
This interface should be implemented by origins which represent an online
account. This means they must have a implement a property representing the
credentials and another representing the account state (online, offline, etc).
 2021-05-04 05:57:42 +02:00
Evangelos Ribeiro Tzaras 5d0de3d299 sip: origin: Use CallsCredentials and adapt to changes 
All parts not related to credentials are now being set when creating the nua
handles and then updated with nua_set_params() when the credentials get updated.
 2021-05-04 05:57:06 +02:00
Evangelos Ribeiro Tzaras 3f72d34c49 Add CallsCredentials class and use it in CallsSipProvider 
CallsCredentials is a dumb container to store account credentials.
This is done in preparation for the account management in the UI.
 2021-05-04 05:57:06 +02:00
Evangelos Ribeiro Tzaras d6916b3510 sip: media-pipeline: Do not set the stream properties prematurely 2021-05-04 05:57:06 +02:00
Evangelos Ribeiro Tzaras 2b5811dc7b flatpak: change URL for boost 
The old one is giving a 403 Forbidden semi regularly.
 2021-05-03 12:18:42 +02:00
Evangelos Ribeiro Tzaras 06076a864a sip: media-pipeline: Fix memory leak in error path 2021-05-02 02:36:31 +02:00
Evangelos Ribeiro Tzaras 9cd13ca681 sip: media-pipeline: Fix memory leak 2021-05-02 02:36:25 +02:00
Evangelos Ribeiro Tzaras 21e72c9e12 sip: origin: Fix nua_authenticate call 
nua_* calls need TAG_END or TAG_NULL as the final parameter.
 2021-05-01 13:59:32 +02:00
Evangelos Ribeiro Tzaras 0d467244b2 test: sip: Connect to state-changed signal 
instead of relying so much on g_timeout_add()
 2021-04-30 09:42:44 +02:00
Evangelos Ribeiro Tzaras 95bde23f2e README: Include code coverage badge 2021-04-27 13:17:55 +00:00
Evangelos Ribeiro Tzaras f9a324fc6f manager: add debug messages when adding or removing origins 2021-04-27 11:39:09 +02:00
Evangelos Ribeiro Tzaras 8a4d408f3f manager: remove unused CallsProvider argument from functions 
Both add_origin() and remove_origin() don't really need it.
 2021-04-27 11:39:09 +02:00
Evangelos Ribeiro Tzaras b71227aae5 call: doc: Indicate ownership in docstrings 2021-04-27 11:38:58 +02:00
Evangelos Ribeiro Tzaras 5ed24c4ed7 doc: Fix gtk-doc transfer annotations 2021-04-27 11:38:26 +02:00
Evangelos Ribeiro Tzaras 0c475a41dd ci: Generate code coverage reports 2021-04-27 04:59:02 +02:00
Evangelos Ribeiro Tzaras 70f1df7e0e build: separate version from the rest of the configuration data 
This should make sure that we always have 'config.h' available and
should fix issues with flatpak build as seen in #257:

`fatal error: config.h: No such file or directory`
 2021-04-27 01:55:13 +02:00
Evangelos Ribeiro Tzaras d7df1a4931 Revert "sip: build: depend on config.h" 
This reverts commit 1a35d6544b.
This has not actually fixed the issue completely. See follow up commit
 2021-04-27 01:51:05 +02:00
Evangelos Ribeiro Tzaras d0194fe534 manager: g_assert in static functions 2021-04-25 18:12:59 +02:00
Evangelos Ribeiro Tzaras c2c3f64102 codestyle: new-call-box 2021-04-25 18:12:59 +02:00
Evangelos Ribeiro Tzaras d65284acaa codestyle: align function prototypes in calls-origin header 
This makes it a easier on the eyes.
 2021-04-25 18:12:59 +02:00
Evangelos Ribeiro Tzaras 868d9e36da codestyle: get rid of CALLS_SET_PTR_PROPERTY macro 
One more step towards fixing #214
In `calls-ofono-call.c` the changed code also adheres to the newly introduced
coding style.
 2021-04-25 18:12:59 +02:00
Evangelos Ribeiro Tzaras 042478a8eb call-record: Get rid of macros 
While these macros are not too bad, they will still be removed for the sake
of consistency (no other purism project uses macros this heavily).

Fixes part of #214
 2021-04-25 18:12:59 +02:00
Evangelos Ribeiro Tzaras 70cb120951 sip: fix typos 
Thanks to lintian for pointing it out!
 2021-04-23 15:35:14 +02:00
Evangelos Ribeiro Tzaras 1593dd299b test: sip: Don't use DNS lookups 
Otherwise build servers might not be happy.
 2021-04-23 15:10:46 +02:00
Evangelos Ribeiro Tzaras 0389137df3 d/control: bump required libhandy 
This was bumped for meson.build in 35f45d83 because of changes
to HdyAvatar
 2021-04-23 13:27:03 +02:00
Evangelos Ribeiro Tzaras 92e58d8ce1 Document and release 0.3.2 2021-04-22 12:17:55 +02:00
Evangelos Ribeiro Tzaras 3cd42c887f d/gbp.conf: set multimaint-merge true 2021-04-22 12:08:51 +02:00
Evangelos Ribeiro Tzaras efe1b12eb5 test: Add calling tests 2021-04-20 09:50:19 +02:00
Evangelos Ribeiro Tzaras cbe1280fb2 test: Use dummy audio elements for Gstreamer pipelines 2021-04-20 09:47:19 +02:00
Evangelos Ribeiro Tzaras 42c1ba7bba test: sip: use g_assert_cmpint for asserting enums 2021-04-20 09:47:19 +02:00
Evangelos Ribeiro Tzaras 2ee6b23475 sip: media-pipeline: Allow overriding audio elements from environment 
This is useful for tests where "pulsesrc" and "pulsesink" GstElements may not
be available (for example in CI).

Additionally only set the echo cancellation and buffer properties for the
pulse GstElements.
 2021-04-20 09:47:16 +02:00
Evangelos Ribeiro Tzaras b5de8f3b8a d/control: Add gstreamer plugins for SIP calling tests 
Otherwise the tests fail with the following message from CallsSipMediaManager:

No supported codecs found. Can't build meaningful SDP message
 2021-04-19 10:52:19 +02:00
Evangelos Ribeiro Tzaras 77419f80bb debian: ran wrap-and-sort -ast 2021-04-19 10:52:19 +02:00
Evangelos Ribeiro Tzaras 4d405e6dcb application: add --version flag 
Closes #256
 2021-04-16 19:57:03 +02:00
Evangelos Ribeiro Tzaras 9a4debe87e codestyle: application 2021-04-16 19:47:01 +02:00
Evangelos Ribeiro Tzaras e5dc3f06ce plugins: make plugins shared modules again 
This reverts the main part of commit 4a264252a7.

As plugins are the prime use case for `shared_module`
getting rid of the warning from meson about linking against shared modules
weighs less heavy.
 2021-04-16 16:41:18 +00:00
Evangelos Ribeiro Tzaras 367ca081a2 sip: call: Don't fail when hanging up on an incoming call 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras f178b3546b sip: provider: document public functions 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras 7ed1ee2502 sip: codestyle changes 
Shuffle the code around and make use of docstrings to conform to
the newly introduced coding style as described in `HACKING.md`

This commit also introduces docstrings describing each source file.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras 765cd2ebb9 sip: pipeline: Only inform of unhandled bus massages when debugging 
These messages are mainly useful for development. This part will be rewritten
once we introduce structured logging. For the moment this will just add noise.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras 166ea8b21a sip: origin: Allow using a local port of 0 
Using a port of 0 let's the operating system decide to which port to bind to.
Additionally refuse to use priviliged ports and print a warning.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras f7626e532f sip: provider: use g_clear_pointer pattern instead of emulating it 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras 6e6873432b sip: provider: Allow overriding SIP account config via environment 
This will make it easier for testing down the line.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras b3cd378704 sip: origin: Remove unnecessary code 
Remove a remnant from early development which has no use anymore
since "direct-connection" is now a property.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras db63efa29f sip: origin: Remove hardcoded display name from contact header 
We might want to set it from the configuration later.
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras b88d432401 sip: origin: make create_inbound a private function 
and shuffle the functions around so that we don't need forward declarations
 2021-04-16 00:39:42 +00:00
Evangelos Ribeiro Tzaras e798d61b83 ci: disable testing in flatpak 
Because it is very flaky currently.
 2021-04-15 18:50:39 +02:00
Evangelos Ribeiro Tzaras 1a35d6544b sip: build: depend on config.h 
Closes #257
 2021-04-15 18:50:39 +02:00
Evangelos Ribeiro Tzaras 436be15f5a build: doc: deduplicate sources 
This is a follow up to 443d23dd56
 2021-04-13 10:53:48 +02:00
Evangelos Ribeiro Tzaras 51a41b249d meson: Fix project name in license header 2021-04-13 10:25:54 +02:00
Evangelos Ribeiro Tzaras 21666fc7d4 best-match: Don't set NULL phone numbers when updating country code 
Also related to #255
 2021-04-12 14:02:26 +02:00
Evangelos Ribeiro Tzaras a072d8c7e3 best-match: avoid using NULL phone number 
Fixes #255
 2021-04-12 14:02:19 +02:00
Evangelos Ribeiro TzarasandGuido Gunther 63cc6507e7 sip: media-manager: fix SDP message when there is no supported codec 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 7d8be1d68d sip: media-manager: fix G_LOG_DOMAIN 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 9502d10970 tests: Test SDP messages 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 2506827c17 tests: Update year in SPDX header 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther d253870509 sip: gst-rfc3551: Add docstrings for public functions 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 2cb8139094 sip: gst-rfc3551: query for plugin availability 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther a5a9f728ae sip: media-pipeline: only create pipeline after codec negotiation 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther c2bd6e9344 sip: media: rework codec negotiation 
introduce `calls_sip_media_manager_get_capabilities ()` which takes
a GList of MediaCodecInfo's as input to generate a SDP message.
If using in an SDP answer we simply feed it a list of the common codecs
as gathered from the SDP offer.
 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 4eb07148cc sip: call: rename setup local/remote connection functions 
Avoid ambiguity by renaming the functions. `setup_local_media ()`
could give the impression that we're setting up media codecs which
is not the case.
 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 157dc1fffb sip: media: use number types for payload id and clock rate 
This is needed for the next commits where we check the received SDP
offers/answers.
 2021-04-12 08:38:24 +00:00
Evangelos Ribeiro TzarasandGuido Gunther 7d113d4180 media: manager: support multiple codecs SDP wise 
static capabilities are now supporting multiple codecs and generate correct SDP
messages. This only relates to SDP offers. When we are answering an offer we
must take the offer from the other party into account when creating the answer.

Hence why we differentiate between "static" and "dynamic" (not implemented yet)
capability strings.
 2021-04-12 08:38:24 +00:00