kbe/backup-agent
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: replace undefined log() calls with echo in dump_db.sh

Browse Source 
dump_users_and_grants() called log(), which dump_db.sh never defines
(only die()/warn() exist) - every real run printed "log: command not
found" on stderr while still completing successfully. Use echo, matching
the rest of the script's style.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
kbe
2026-07-25 21:37:56 +02:00
co-authored by Claude Sonnet 5
parent dc414de14e
commit 511c95063d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dump_db.sh
+3 -3
View File
@@ -125,18 +125,18 @@ dump_users_and_grants() {
if "$DUMPER" --help 2>&1 | grep -q -- ' --users '; then if "$DUMPER" --help 2>&1 | grep -q -- ' --users '; then
# MySQL 8.0.31+: --users dumps CREATE USER + GRANT statements only # MySQL 8.0.31+: --users dumps CREATE USER + GRANT statements only
# (when no --databases / --all-databases is given) # (when no --databases / --all-databases is given)
log "[dump] using mysqldump --users (MySQL 8.0.31+ style)" echo "[dump] using mysqldump --users (MySQL 8.0.31+ style)"
db_exec "$DUMPER" -u "$DB_USER" --users \ db_exec "$DUMPER" -u "$DB_USER" --users \
>"$out" 2>/dev/null >"$out" 2>/dev/null
elif docker exec "$CONTAINER" sh -c "command -v mariadb-dump" >/dev/null 2>&1 && elif docker exec "$CONTAINER" sh -c "command -v mariadb-dump" >/dev/null 2>&1 &&
docker exec "$CONTAINER" mariadb-dump --help 2>&1 | grep -q -- ' --system '; then docker exec "$CONTAINER" mariadb-dump --help 2>&1 | grep -q -- ' --system '; then
# MariaDB: --system=users # MariaDB: --system=users
log "[dump] using mariadb-dump --system=users" echo "[dump] using mariadb-dump --system=users"
db_exec "$DUMPER" -u "$DB_USER" --system=users \ db_exec "$DUMPER" -u "$DB_USER" --system=users \
>"$out" 2>/dev/null >"$out" 2>/dev/null
else else
# Fallback: full mysql schema dump # Fallback: full mysql schema dump
log "[dump] falling back to full mysql schema dump (older server)" echo "[dump] falling back to full mysql schema dump (older server)"
db_exec "$DUMPER" "${DUMP_OPTS[@]}" --databases mysql \ db_exec "$DUMPER" "${DUMP_OPTS[@]}" --databases mysql \
>"$out" 2>/dev/null >"$out" 2>/dev/null
fi fi