From 511c95063dbdf4789519bc94ed9570b98bd7b644 Mon Sep 17 00:00:00 2001 From: Kevin Bataille Date: Sat, 25 Jul 2026 21:37:56 +0200 Subject: [PATCH] fix: replace undefined log() calls with echo in dump_db.sh dump_users_and_grants() called log(), which dump_db.sh never defines (only die()/warn() exist) - every real run printed "log: command not found" on stderr while still completing successfully. Use echo, matching the rest of the script's style. Co-Authored-By: Claude Sonnet 5 --- dump_db.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dump_db.sh b/dump_db.sh index 5c8140d..7dd53e6 100755 --- a/dump_db.sh +++ b/dump_db.sh @@ -125,18 +125,18 @@ dump_users_and_grants() { if "$DUMPER" --help 2>&1 | grep -q -- ' --users '; then # MySQL 8.0.31+: --users dumps CREATE USER + GRANT statements only # (when no --databases / --all-databases is given) - log "[dump] using mysqldump --users (MySQL 8.0.31+ style)" + echo "[dump] using mysqldump --users (MySQL 8.0.31+ style)" db_exec "$DUMPER" -u "$DB_USER" --users \ >"$out" 2>/dev/null elif docker exec "$CONTAINER" sh -c "command -v mariadb-dump" >/dev/null 2>&1 && docker exec "$CONTAINER" mariadb-dump --help 2>&1 | grep -q -- ' --system '; then # MariaDB: --system=users - log "[dump] using mariadb-dump --system=users" + echo "[dump] using mariadb-dump --system=users" db_exec "$DUMPER" -u "$DB_USER" --system=users \ >"$out" 2>/dev/null else # Fallback: full mysql schema dump - log "[dump] falling back to full mysql schema dump (older server)" + echo "[dump] falling back to full mysql schema dump (older server)" db_exec "$DUMPER" "${DUMP_OPTS[@]}" --databases mysql \ >"$out" 2>/dev/null fi