Get rid of the duplication by rolling (almost) every test into a loop.
We now iterate over an array containing at least the name and list of sources.
To account for some differences between individual tests, we allow an
optional third array consisting of a dictionary for extra arguments.
In particular we ensure that the `test()` target now always depends on
the test binary, so that it will get properly rebuilt on changes to
the sources.
Note, that we're resorting in a separate commit, to ease reviewing.
Signed-off-by: Evangelos Ribeiro Tzaras <devrtz@fortysixandtwo.eu>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/798>
While the test was correct and checked if there is only
`record.db` in a given dir (and no other files) it wouldn't
tell us whether the file wasn't there or there were additional
files found. Hence replace the test by assertions that tell
use exactly what failed easing debugging in CI.
Fixes: e4bd4580 ("tests: Add application shutdown tests")
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/795>
A toolbar view, per its docs, expects its toolbar
children to either be of a set of known widget types that
are supported by default, or otherwise be a Gtk.Box-like
container with the .toolbar CSS style class.
This expectation was not met, but instead similar, but
not identical margins manually applied. These similar yet
different margins made it look off.
While this now adheres to the toolbar child requirements
of libadwaita, and the margins look more familiar, it
still breaks with libadwaita's assumption that toolbars
are not stacked. Its stylesheet allows for stacking
toolbar views only if one is providing the top and the
other the bottom one.
This view, especially, deserves a more thorough design
overhaul, regardless of this. Thus, I will leave it at
this.
Link: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/class.ToolbarView.html
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
It was possible to increase the window's size below the
minimum size of the dialer view. As such it is important
to wrap it in a scrolled window in order not to lose
access to otherwise hidden interface components.
This is, of course, not a replacement for a better
adapting dialer.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
The toolbar view is meant for these. This allows
libadwaita's style to apply the way it can be seen in
basically every other GNOME app.
The differences are with the scroll dependent undershoot
instead of an unconditional border.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
The current breakpoint is more or less perfect for
English. However, there are other languages with longer
strings there, such as German. Increasing the width at
which the breakpoint sits to switch the switcher location
enables most languages to have no or minimal ellipses
while not looking too spacious with English.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/791>
This also aligns it a bit more with the Flathub build
description.
It also builds more dependencies from main or master
branches, especially GNOME ones. That should allow (a)
future breaking changes be found early, and (b) to let
the Flatpak build description sit otherwise with less
maintenance for simple version bumps.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/792>
Rather use gapplication service. This makes the flow similar to what
Chatty does and makes us hold/release rather than having an application
window.
It also allows us to drop the --daemon.
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/760>
The activate method is used when the application is activated via
various means - e.g. via the `Activate` DBus method. We don't want to
ignore that activation just because calls was started with the
`--daemon` option. Rename the variable to better match what it means.
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/760>
This makes sure it gets correctly activated when launched e.g. in
phosh while calls is running in `--daemon` mode as the necessary
platform data containing the activation token is now passed via DBus.
This also helps situations when e.g. pressing the call button in chatty
or contacts.
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/760>
