From ef9db6ce844551bac3a2ad9713b18a092a69fbfd Mon Sep 17 00:00:00 2001
From: knoppix <knoppix@4d2.org>
Date: Mon, 28 Apr 2025 16:23:07 -0500
Subject: [PATCH] main-window.ui: add a proper callback for Close button

The signal click of Close button is connected to "gtk_widget_hide".
As a result the window is hided, but still active and the whole
program renders unresponsive.

The Close button can appear for example if USSD_STATUS_IDLE comes
before a user press Cancel button in dialog window
(could be for example because of carrier timeout).
The "adw_dialog_close" function should be called instead.

Signed-off-by: knoppix <knoppix@4d2.org>
Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/776>
---
 src/calls-main-window.c | 1 -
 src/ui/main-window.ui   | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/calls-main-window.c b/src/calls-main-window.c
index 1f22281..126e7ad 100644
--- a/src/calls-main-window.c
+++ b/src/calls-main-window.c
@@ -201,7 +201,6 @@ window_ussd_cancel_clicked_cb (CallsMainWindow *self)
   adw_dialog_close (self->ussd_dialog);
 }
 
-
 static void
 window_ussd_entry_changed_cb (CallsMainWindow *self,
                               GtkEntry        *entry)
diff --git a/src/ui/main-window.ui b/src/ui/main-window.ui
index 3531e9d..db78419 100644
--- a/src/ui/main-window.ui
+++ b/src/ui/main-window.ui
@@ -85,7 +85,7 @@
                 <property name="focus-on-click">False</property>
                 <property name="use-underline">True</property>
                 <property name="label" translatable="yes">_Close</property>
-                <signal name="clicked" handler="gtk_widget_hide" object="ussd_dialog" swapped="yes"/>
+                <signal name="clicked" handler="adw_dialog_close" object="ussd_dialog" swapped="yes"/>
               </object>
             </child>
             <child type="end">