From caecf10cc19f409418eb9e4af65a641e1555cf80 Mon Sep 17 00:00:00 2001
From: Anton Lazarev <antonok35@gmail.com>
Date: Thu, 11 Jan 2024 23:06:37 -0800
Subject: [PATCH] treewide: Remove `visible=True` on adwaita widgets

Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/714>
---
 plugins/provider/sip/sip-account-widget.ui | 16 ----------------
 src/ui/account-overview.ui                 |  3 ---
 src/ui/account-row.ui                      |  2 --
 src/ui/call-record-row.ui                  |  1 -
 src/ui/contacts-box.ui                     |  1 -
 src/ui/contacts-row.ui                     |  1 -
 src/ui/history-box.ui                      |  2 --
 src/ui/main-window.ui                      |  4 ----
 src/ui/new-call-box.ui                     |  3 ---
 9 files changed, 33 deletions(-)

diff --git a/plugins/provider/sip/sip-account-widget.ui b/plugins/provider/sip/sip-account-widget.ui
index fba912a..b3b62dc 100644
--- a/plugins/provider/sip/sip-account-widget.ui
+++ b/plugins/provider/sip/sip-account-widget.ui
@@ -24,7 +24,6 @@
         </child>
         <child type="top">
           <object class="AdwHeaderBar" id="header_edit">
-            <property name="visible">True</property>
             <child type="end">
               <object class="GtkButton" id="apply_btn">
                 <property name="use-underline">True</property>
@@ -52,13 +51,10 @@
         </child>
         <property name="content">
           <object class="AdwPreferencesPage">
-            <property name="visible">True</property>
             <child>
               <object class="AdwPreferencesGroup">
-                <property name="visible">True</property>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Server</property>
                     <child>
                       <object class="GtkEntry" id="host">
@@ -72,10 +68,8 @@
             </child>
             <child>
               <object class="AdwPreferencesGroup">
-                <property name="visible">True</property>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Display Name</property>
                     <property name="subtitle" translatable="yes">Optional</property>
                     <child>
@@ -90,10 +84,8 @@
             </child>
             <child>
               <object class="AdwPreferencesGroup">
-                <property name="visible">True</property>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">User ID</property>
                     <child>
                       <object class="GtkEntry" id="user">
@@ -105,7 +97,6 @@
                 </child>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Password</property>
                     <child>
                       <object class="GtkEntry" id="password">
@@ -124,10 +115,8 @@
             </child>
             <child>
               <object class="AdwPreferencesGroup">
-                <property name="visible">True</property>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Port</property>
                     <child>
                       <object class="GtkEntry" id="port">
@@ -142,14 +131,12 @@
                 </child>
                 <child>
                   <object class="AdwComboRow" id="protocol">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Transport</property>
                     <signal name="notify::selected-index" handler="on_user_changed" swapped="yes"/>
                   </object>
                 </child>
                 <child>
                   <object class="AdwComboRow" id="media_encryption">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Media Encryption</property>
                     <signal name="notify::selected-index" handler="on_user_changed" swapped="yes"/>
                   </object>
@@ -158,10 +145,8 @@
             </child>
             <child>
               <object class="AdwPreferencesGroup">
-                <property name="visible">True</property>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Use for Phone Calls</property>
                     <child>
                       <object class="GtkSwitch" id="tel_switch">
@@ -173,7 +158,6 @@
                 </child>
                 <child>
                   <object class="AdwActionRow">
-                    <property name="visible">True</property>
                     <property name="title" translatable="yes">Automatically Connect</property>
                     <child>
                       <object class="GtkSwitch" id="auto_connect_switch">
diff --git a/src/ui/account-overview.ui b/src/ui/account-overview.ui
index d7c968c..30e54af 100644
--- a/src/ui/account-overview.ui
+++ b/src/ui/account-overview.ui
@@ -3,7 +3,6 @@
   <requires lib="gtk" version="4.0"/>
   <requires lib="libadwaita" version="1.0"/>
   <template class="CallsAccountOverview" parent="AdwWindow">
-    <property name="visible">True</property>
     <property name="default-width">380</property>
     <property name="default-height">660</property>
     <property name="hide-on-close">True</property>
@@ -11,7 +10,6 @@
       <object class="AdwToolbarView">
         <child type="top">
           <object class="AdwHeaderBar">
-            <property name="visible">True</property>
             <child type="end">
               <object class="GtkSpinner" id="spinner"/>
             </child>
@@ -28,7 +26,6 @@
                     <property name="name">intro-page</property>
                     <property name="child">
                       <object class="AdwStatusPage" id="intro">
-                        <property name="visible">True</property>
                         <property name="title" translatable="yes">Add VoIP Accounts</property>
                         <property name="icon-name">system-users-symbolic</property>
                         <property name="description" translatable="yes">You can add VoIP account here. It will allow you to place and receive VoIP calls using the SIP protocol. This feature is still relatively new and not yet feature complete (i.e. no encrypted media).</property>
diff --git a/src/ui/account-row.ui b/src/ui/account-row.ui
index 29ec1bf..a3c0832 100644
--- a/src/ui/account-row.ui
+++ b/src/ui/account-row.ui
@@ -3,13 +3,11 @@
   <requires lib="gtk" version="4.0"/>
   <requires lib="libadwaita" version="1.0"/>
   <template class="CallsAccountRow" parent="AdwActionRow">
-    <property name="visible">True</property>
     <property name="title">Title</property>
     <property name="subtitle">Subtitle</property>
     <property name="activatable">True</property>
     <child type="prefix">
       <object class="AdwAvatar" id="avatar">
-        <property name="visible">True</property>
         <property name="show-initials">True</property>
         <property name="size">48</property>
       </object>
diff --git a/src/ui/call-record-row.ui b/src/ui/call-record-row.ui
index 8cc7e5c..5165760 100644
--- a/src/ui/call-record-row.ui
+++ b/src/ui/call-record-row.ui
@@ -10,7 +10,6 @@
           <object class="GtkBox">
             <child>
               <object class="AdwAvatar" id="avatar">
-                <property name="visible">True</property>
                 <property name="margin-start">8</property>
                 <property name="margin_top">8</property>
                 <property name="margin_bottom">8</property>
diff --git a/src/ui/contacts-box.ui b/src/ui/contacts-box.ui
index 2bb5d3e..ded07d9 100644
--- a/src/ui/contacts-box.ui
+++ b/src/ui/contacts-box.ui
@@ -9,7 +9,6 @@
         <property name="vexpand">True</property>
         <child>
           <object class="AdwClamp">
-            <property name="visible">True</property>
             <child>
               <object class="GtkBox">
                 <property name="orientation">vertical</property>
diff --git a/src/ui/contacts-row.ui b/src/ui/contacts-row.ui
index 23c4036..f1f76d2 100644
--- a/src/ui/contacts-row.ui
+++ b/src/ui/contacts-row.ui
@@ -14,7 +14,6 @@
         <property name="row-spacing">3</property>
         <child>
           <object class="AdwAvatar" id="avatar">
-            <property name="visible">True</property>
             <property name="valign">center</property>
             <property name="size">36</property>
             <property name="show-initials">True</property>
diff --git a/src/ui/history-box.ui b/src/ui/history-box.ui
index f0f46ba..fbb54a0 100644
--- a/src/ui/history-box.ui
+++ b/src/ui/history-box.ui
@@ -10,7 +10,6 @@
             <property name="name">empty</property>
             <property name="child">
               <object class="AdwStatusPage">
-                <property name="visible">True</property>
                 <property name="icon-name">call-start-symbolic</property>
                 <property name="title" translatable="yes">No Recent Calls</property>
               </object>
@@ -25,7 +24,6 @@
                 <property name="hscrollbar-policy">never</property>
                 <child>
                   <object class="AdwClamp">
-                    <property name="visible">True</property>
                     <child>
                       <object class="GtkListBox" id="history">
                         <property name="margin-start">12</property>
diff --git a/src/ui/main-window.ui b/src/ui/main-window.ui
index 8586aaf..e02b19f 100644
--- a/src/ui/main-window.ui
+++ b/src/ui/main-window.ui
@@ -10,11 +10,9 @@
       <object class="AdwToolbarView">
         <child type="top">
           <object class="AdwHeaderBar">
-            <property name="visible">True</property>
             <property name="centering_policy">strict</property>
             <child type="title">
               <object class="AdwViewSwitcherTitle" id="title_switcher">
-                <property name="visible">True</property>
                 <property name="stack">main_stack</property>
                 <property name="title" bind-source="CallsMainWindow" bind-property="title" bind-flags="sync-create"/>
               </object>
@@ -56,7 +54,6 @@
                 </child>
                 <child>
                   <object class="AdwViewSwitcherBar" id="switcher_bar">
-                    <property name="visible">True</property>
                     <property name="stack">main_stack</property>
                     <property name="reveal" bind-source="title_switcher" bind-property="title-visible" bind-flags="sync-create"/>
                   </object>
@@ -76,7 +73,6 @@
     <property name="default-widget">ussd_cancel_button</property>
     <child type="titlebar">
       <object class="AdwHeaderBar">
-        <property name="visible">True</property>
         <property name="show-start-title-buttons">False</property>
         <property name="show-end-title-buttons">False</property>
         <child type="start">
diff --git a/src/ui/new-call-box.ui b/src/ui/new-call-box.ui
index ba57b2e..d0d2017 100644
--- a/src/ui/new-call-box.ui
+++ b/src/ui/new-call-box.ui
@@ -11,7 +11,6 @@
         <property name="orientation">vertical</property>
         <child>
           <object class="AdwClamp">
-            <property name="visible">True</property>
             <property name="orientation">vertical</property>
             <child>
               <object class="GtkBox">
@@ -22,7 +21,6 @@
                     <property name="halign">center</property>
                     <child>
                       <object class="AdwComboRow" id="origin_list">
-                        <property name="visible">True</property>
                         <signal name="notify::selected-index" handler="notify_selected_index_cb" swapped="yes"/>
                       </object>
                     </child>
@@ -59,7 +57,6 @@
                         <property name="subtitle" translatable="yes">SIP Account</property>
                         <child type="prefix">
                           <object class="AdwAvatar">
-                            <property name="visible">True</property>
                             <property name="show-initials">True</property>
                             <property name="size">36</property>
                           </object>