kbe/calls
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

codestyle: get rid of CALLS_SET_PTR_PROPERTY macro

Browse Source 
One more step towards fixing #214
In `calls-ofono-call.c` the changed code also adheres to the newly introduced
coding style.
This commit is contained in:
Evangelos Ribeiro Tzaras
2021-04-12 11:33:57 +02:00
parent 042478a8eb
commit 868d9e36da
3 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/ofono/calls-ofono-call.c
View File

@@ -25,7 +25,6 @@
#include "calls-ofono-call.h" #include "calls-ofono-call.h"
#include "calls-call.h" #include "calls-call.h"
#include "calls-message-source.h" #include "calls-message-source.h"
#include "util.h"
#include <glib/gi18n.h> #include <glib/gi18n.h>
@@ -287,11 +286,10 @@ static void
disconnect_reason_cb (CallsOfonoCall *self, disconnect_reason_cb (CallsOfonoCall *self,
const gchar *reason) const gchar *reason)
{ {
if (reason) if (reason) {
{ g_free (self->disconnect_reason);
CALLS_SET_PTR_PROPERTY (self->disconnect_reason, self->disconnect_reason = g_strdup (reason);
g_strdup (reason)); }
}
} }

4
src/calls-call-record.c
View File

@@ -23,7 +23,6 @@
*/ */
#include "calls-call-record.h" #include "calls-call-record.h"
#include "util.h"
#include <glib/gi18n.h> #include <glib/gi18n.h>
@@ -132,7 +131,8 @@ set_property (GObject *object,
break; break;
case PROP_TARGET: case PROP_TARGET:
CALLS_SET_PTR_PROPERTY (self->target, g_value_dup_string (value)); g_free (self->target);
self->target = g_value_dup_string (value);
break; break;
case PROP_INBOUND: case PROP_INBOUND:

5
src/util.h
View File

@@ -88,11 +88,6 @@ G_BEGIN_DECLS
CALLS_DEFINE_IFACE_GETTER_BASE(calls,iface,Calls,Iface,CALLS,IFACE,prop,rettype,errval) CALLS_DEFINE_IFACE_GETTER_BASE(calls,iface,Calls,Iface,CALLS,IFACE,prop,rettype,errval)
#define CALLS_SET_PTR_PROPERTY(ptr,new_value) \
g_free (ptr); \
ptr = new_value;
#define calls_clear_source(source_id_ptr) \ #define calls_clear_source(source_id_ptr) \
if (*source_id_ptr != 0) \ if (*source_id_ptr != 0) \
{ \ { \