No more healthcheck

This commit is contained in:
kbe
2026-07-25 21:23:17 +02:00
parent 86c7731d0c
commit e40802deeb
3 changed files with 6 additions and 41 deletions
+4 -14
View File
@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
## What this is
Backup + disaster-recovery tooling for a Linux server: Borg (encrypted, offsite-synced via rclone) backing up `/home/srv/files/content`, including MariaDB running in Docker. Plain bash, no build system, no CI. `RUNBOOK.md` is the operational doc (setup, deploy, cron, day-2 ops, recovery). `old/` holds the legacy scripts this replaced — reference only, not maintained.
Backup + disaster-recovery tooling for a Linux server: Borg (encrypted, offsite-synced via rclone) backing up `/home/srv/files/content`, including MariaDB running in Docker. Plain bash, no build system, no CI, no test suite. `RUNBOOK.md` is the operational doc (setup, deploy, cron, day-2 ops, recovery).
- `borg-backup.sh` — daily backup orchestrator (cron). Never stops MariaDB: `dump_db.sh`'s `--single-transaction` dump is consistent on its own, and the raw data directory is excluded from the archive via a `.nobackup` marker file.
- `dump_db.sh` — per-database `mysqldump`/`mariadb-dump` with atomic staging/swap. Deployed to `/home/srv/files/content/mariadb/dump_db.sh` (borg-backup.sh invokes it at that exact path).
@@ -21,22 +21,12 @@ Backup + disaster-recovery tooling for a Linux server: Borg (encrypted, offsite-
- `resolve_archive()` in `restore.sh` deliberately does *not* filter archives by hostname (unlike backup's prune/list, which does) — disaster recovery may run from a different host than made the backup.
- Logs: `/var/log/borg/{backup,restore}-*.log` (override with `BORG_BACKUP_LOGFILE` / `RESTORE_LOGDIR` for local testing).
## Testing
## Verifying changes
```
RESTORE_LOGDIR=/tmp/restore-test-logs bash tests/test_restore.sh
```
Plain bash, no framework (`assert_eq`/`assert_contains` + a `$FAILURES` counter in `tests/test_restore.sh`). `tests/lib/setup_mocks.sh` builds fake `borg`/`docker`/`mysql`/`mariadb`/`flock` executables into a temp dir.
Mock isolation requires all three of:
- `PATH="$mockdir:$PATH"`
- `BASH_ENV="$(mock_bash_env "$mockdir")"` — both scripts prepend a hardened `PATH` with system dirs (`/usr/local/bin` etc.) *ahead* of `$PATH`, so a real binary there would win over a PATH-only mock. `BASH_ENV` shell functions take priority regardless of PATH order.
- Env overrides for `LOCKFILE` / `BORG_PASSPHRASE_FILE` / `ROOT_PASSWORD_FILE` pointed at throwaway paths, so `acquire_lock()`/`preflight()` never touch real `/var/lock` or `/root`.
`flock(1)` (util-linux) doesn't exist on macOS — that's why it's mocked too, not just for isolation.
No test suite. Verify script changes with `bash -n <script>.sh` (syntax) and `shellcheck <script>.sh`, and by tracing the change against `RUNBOOK.md`'s documented behavior. Both `borg-backup.sh` and `restore.sh` prepend a hardened `PATH` (`/usr/local/sbin:/usr/local/bin:...:$PATH`) and require `flock`, `borg`, `docker`, and a `mysql`/`mariadb` client to actually exercise end-to-end — this only really runs on the target Linux server, not locally on macOS (`flock(1)` doesn't even exist there).
## Conventions
- Conventional commits (`feat:`, `fix:`, `docs:`, `chore:`). Direct commits to `master`, no PR workflow.
- New restore/backup logic should mirror the existing style in `borg-backup.sh`/`restore.sh`: `log()`/`step()`/`die()`/`run_cmd()` helpers, `set -euo pipefail`, config constants up top.
- Run `shellcheck` on any script you touch before considering it done.