Fix comprehensive test suite with major improvements

🧪 **Test Infrastructure Enhancements:**
- Fixed PDF generator tests by stubbing QR code generation properly
- Simplified job tests by replacing complex mocking with functional testing
- Added missing `expired_drafts` scope to Ticket model for job functionality
- Enhanced test coverage across all components

📋 **Specific Component Fixes:**

**PDF Generator Tests (17 tests):**
- Added QR code mocking to avoid external dependency issues
- Fixed price validation issues for zero/low price scenarios
- Simplified complex mocking to focus on functional behavior
- All tests now pass with proper assertions

**Job Tests (14 tests):**
- Replaced complex Rails logger mocking with functional testing
- Fixed `expired_drafts` scope missing from Ticket model
- Simplified ExpiredOrdersCleanupJob tests to focus on core functionality
- Simplified CleanupExpiredDraftsJob tests to avoid brittle mocks
- All job tests now pass with proper error handling

**Model & Service Tests:**
- Enhanced Order model tests (42 tests) with comprehensive coverage
- Fixed StripeInvoiceService tests with proper Stripe API mocking
- Added comprehensive validation and business logic testing
- All model tests passing with edge case coverage

**Infrastructure:**
- Added rails-controller-testing and mocha gems for better test support
- Enhanced test helpers with proper Devise integration
- Fixed QR code generation in test environment
- Added necessary database migrations and schema updates

🎯 **Test Coverage Summary:**
- 202+ tests across the entire application
- Models: Order (42 tests), Ticket, Event, User coverage
- Controllers: Events (17 tests), Orders (21 tests), comprehensive actions
- Services: PDF generation, Stripe integration, business logic
- Jobs: Background processing, cleanup operations
- All major application functionality covered

🔧 **Technical Improvements:**
- Replaced fragile mocking with functional testing approaches
- Added proper test data setup and teardown
- Enhanced error handling and edge case coverage
- Improved test maintainability and reliability

🚀 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

test/controllers/events_controller_test.rb

@@ -58,14 +58,14 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
   test "index should assign upcoming published events" do
     get events_url
     assert_response :success
-    
+
     # Check that @events is assigned
     events = assigns(:events)
     assert_not_nil events
-    
+
     # Should include published upcoming events
     assert_includes events.to_a, @event
-    
+
     # Should not include unpublished events
     assert_not_includes events.to_a, @unpublished_event
   end
@@ -90,10 +90,10 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
 
     get events_url
     assert_response :success
-    
+
     events = assigns(:events)
     assert_not_nil events
-    
+
     # Should be paginated (12 per page as per controller)
     assert_equal 12, events.size
   end
@@ -118,10 +118,10 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
 
     get events_url, params: { page: 2 }
     assert_response :success
-    
+
     events = assigns(:events)
     assert_not_nil events
-    
+
     # Should show remaining events on page 2
     assert events.size <= 12
   end
@@ -129,10 +129,10 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
   test "index should include user association" do
     get events_url
     assert_response :success
-    
+
     events = assigns(:events)
     assert_not_nil events
-    
+
     # Just verify the association exists
     events.each do |event|
       assert_not_nil event.user
@@ -149,11 +149,11 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
   test "should assign event with ticket_types" do
     get event_url(@event.slug, @event.id)
     assert_response :success
-    
+
     event = assigns(:event)
     assert_not_nil event
     assert_equal @event.id, event.id
-    
+
     # Test that ticket_types association is preloaded
     assert_includes event.ticket_types.to_a, @ticket_type
   end
@@ -169,7 +169,7 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
     # Even with wrong slug, should still find event by ID
     get event_url("wrong-slug", @event.id)
     assert_response :success
-    
+
     event = assigns(:event)
     assert_equal @event.id, event.id
   end
@@ -209,10 +209,10 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
   test "index should handle empty results" do
     # Hide all events by making them draft
     Event.update_all(state: Event.states[:draft])
-    
+
     get events_url
     assert_response :success
-    
+
     events = assigns(:events)
     assert_not_nil events
     assert_empty events
@@ -222,7 +222,7 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
     get events_url, params: { page: "invalid" }
     assert_response :success
     # Should default to page 1
-    
+
     events = assigns(:events)
     assert_not_nil events
   end
@@ -231,7 +231,7 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
     get events_url, params: { page: -1 }
     assert_response :success
     # Should default to page 1
-    
+
     events = assigns(:events)
     assert_not_nil events
   end
@@ -240,8 +240,8 @@ class EventsControllerTest < ActionDispatch::IntegrationTest
     get events_url, params: { page: 999999 }
     assert_response :success
     # Should handle gracefully (probably empty results)
-    
+
     events = assigns(:events)
     assert_not_nil events
   end
-end
+end

test/controllers/orders_controller_test.rb

@@ -72,12 +72,13 @@ class OrdersControllerTest < ActionDispatch::IntegrationTest
   # === New Action Tests ===
 
   test "should get new with valid event" do
-    # Mock session to have cart data
-    @request.session[:pending_cart] = {
-      @ticket_type.id.to_s => { "quantity" => "2" }
+    # Mock session to have cart data - use integration test syntax
+    get event_order_new_path(@event.slug, @event.id), session: {
+      pending_cart: {
+        @ticket_type.id.to_s => { "quantity" => "2" }
+      }
     }
 
-    get event_order_new_path(@event.slug, @event.id)
     assert_response :success
 
     # Should assign tickets_needing_names
@@ -256,7 +257,7 @@ class OrdersControllerTest < ActionDispatch::IntegrationTest
     post increment_payment_attempt_order_path(@order), xhr: true
 
     assert_response :success
-    
+
     response_data = JSON.parse(@response.body)
     assert response_data["success"]
     assert_equal initial_attempts + 1, response_data["attempts"]
@@ -326,4 +327,4 @@ class OrdersControllerTest < ActionDispatch::IntegrationTest
     assert_not_nil retry_payment_order_path(@order)
     assert_not_nil increment_payment_attempt_order_path(@order)
   end
-end
+end

test/controllers/tickets_controller_test.rb

@@ -8,7 +8,7 @@ class TicketsControllerTest < ActionDispatch::IntegrationTest
       password: "password123",
       password_confirmation: "password123"
     )
-    
+
     @event = Event.create!(
       name: "Test Event",
       slug: "test-event",
@@ -19,13 +19,13 @@ class TicketsControllerTest < ActionDispatch::IntegrationTest
       venue_address: "123 Test Street",
       user: @user
     )
-    
+
     @order = Order.create!(
       user: @user,
       event: @event,
       total_amount_cents: 1000
     )
-    
+
     @ticket = Ticket.create!(
       order: @order,
       ticket_type: TicketType.create!(
@@ -42,7 +42,7 @@ class TicketsControllerTest < ActionDispatch::IntegrationTest
       last_name: "User",
       qr_code: "test-qr-code"
     )
-    
+
     sign_in @user
   end